Wasmtime GitHub notifications bot (Dec 02 2024 at 21:07): Wasmtime GitHub notifications bot (Dec 02 2024 at 21:07):saulecabrera requested cfallin for a review on PR #9709.
Wasmtime GitHub notifications bot (Dec 02 2024 at 21:07):saulecabrera opened PR #9709 from saulecabrera:winch-use-without-fuel to bytecodealliance:main:
This commit is a follow-up to
https://github.com/bytecodealliance/wasmtime/pull/9472. It ensures that the fuel checking code makes use ofContext::withoutto retrieve the current fuel register.Even though no issues have been found, it is preferable to use
Context::withoutin scenarios in which we have to introduce special out-of-band control flow and function calls to ensure that all the register allocation invariants are respected i.e., avoid holding onto to registers that: are not in the stack and that might be needed for function calls.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 02 2024 at 21:07):saulecabrera requested wasmtime-compiler-reviewers for a review on PR #9709.
Wasmtime GitHub notifications bot (Dec 02 2024 at 22:45):github-actions[bot] commented on PR #9709:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Dec 04 2024 at 16:53):cfallin submitted PR review:
LGTM!
Wasmtime GitHub notifications bot (Dec 04 2024 at 17:10):cfallin merged PR #9709.
Last updated: Dec 23 2024 at 12:05 UTC