Wasmtime GitHub notifications bot (Dec 02 2024 at 19:33): Wasmtime GitHub notifications bot (Dec 02 2024 at 19:33):SingleAccretion opened PR #9706 from SingleAccretion:DI-WinSym to bytecodealliance:main:
This allows the debugger to find them.
After much research, this has been chosen as the overall best solution to #9657. The alternative here would be to create machine code thunks that call these symbols when Jitting code, and describing those thunks in DWARF, which would be significantly more complex.
Wasmtime GitHub notifications bot (Dec 02 2024 at 19:39):SingleAccretion updated PR #9706.
Wasmtime GitHub notifications bot (Dec 02 2024 at 19:42):SingleAccretion edited PR #9706:
This allows the debugger to find them.
After much research, this has been chosen as the overall best solution to #9657. The alternative here would be to create machine code thunks that call these symbols when Jitting code, and describing those thunks in DWARF, which would be significantly more complex.
Closes #9657.
Wasmtime GitHub notifications bot (Dec 02 2024 at 19:50):SingleAccretion updated PR #9706.
Wasmtime GitHub notifications bot (Dec 02 2024 at 19:56):SingleAccretion updated PR #9706.
Wasmtime GitHub notifications bot (Dec 02 2024 at 20:09):SingleAccretion updated PR #9706.
Wasmtime GitHub notifications bot (Dec 02 2024 at 20:15):SingleAccretion updated PR #9706.
Wasmtime GitHub notifications bot (Dec 02 2024 at 20:25):SingleAccretion has marked PR #9706 as ready for review.
Wasmtime GitHub notifications bot (Dec 02 2024 at 20:25):SingleAccretion requested alexcrichton for a review on PR #9706.
Wasmtime GitHub notifications bot (Dec 02 2024 at 20:25):SingleAccretion requested wasmtime-core-reviewers for a review on PR #9706.
Wasmtime GitHub notifications bot (Dec 02 2024 at 20:31):alexcrichton submitted PR review:
Sounds reasonable to me, thanks again for investigating this!
Wasmtime GitHub notifications bot (Dec 02 2024 at 20:48):alexcrichton merged PR #9706.
Last updated: Dec 23 2024 at 12:05 UTC