Stream: git-wasmtime

Topic: wasmtime / PR #9703 Update wasm-tools crates

Wasmtime GitHub notifications bot (Dec 02 2024 at 18:09):

alexcrichton opened PR #9703 from alexcrichton:update-wasm-tools to bytecodealliance:main:

Mostly comes with a split in wasmparser of simd/other ops since it's now possible to disable the simd feature at compile time (which we don't use in Wasmtime right now).

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Dec 02 2024 at 18:09):

alexcrichton has marked PR #9703 as ready for review.

Wasmtime GitHub notifications bot (Dec 02 2024 at 18:09):

alexcrichton requested cfallin for a review on PR #9703.

Wasmtime GitHub notifications bot (Dec 02 2024 at 18:09):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9703.

Wasmtime GitHub notifications bot (Dec 02 2024 at 18:09):

alexcrichton requested pchickey for a review on PR #9703.

Wasmtime GitHub notifications bot (Dec 02 2024 at 18:09):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9703.

Wasmtime GitHub notifications bot (Dec 02 2024 at 18:09):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9703.

Wasmtime GitHub notifications bot (Dec 02 2024 at 18:35):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Dec 02 2024 at 18:37):

alexcrichton updated PR #9703.

Wasmtime GitHub notifications bot (Dec 02 2024 at 18:40):

alexcrichton commented on PR #9703:

Upstream in wasm-tools the test suite for spec tests has stopped asserting that the spec-provided error message matches the wasmparser-provided error message. That means that the error-message-matching here in Wasmtime also needs to go since the same "failures" were cropping up there. I've adjusted the function to match errors in a similar way now which caused some tests to start passing. I think the new tests "passing" are probably where the error before was "wasmtime doesn't support this wasm instruction" and the expected error is something like "type mismatch" which would explain that.

Wasmtime GitHub notifications bot (Dec 02 2024 at 18:40):

alexcrichton has enabled auto merge for PR #9703.

Wasmtime GitHub notifications bot (Dec 02 2024 at 18:59):

alexcrichton updated PR #9703.

Wasmtime GitHub notifications bot (Dec 02 2024 at 18:59):

alexcrichton has enabled auto merge for PR #9703.

Wasmtime GitHub notifications bot (Dec 02 2024 at 20:45):

github-actions[bot] commented on PR #9703:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Dec 02 2024 at 22:50):

alexcrichton updated PR #9703.

Wasmtime GitHub notifications bot (Dec 02 2024 at 22:51):

alexcrichton has enabled auto merge for PR #9703.

Wasmtime GitHub notifications bot (Dec 02 2024 at 23:17):

alexcrichton merged PR #9703.

Last updated: Dec 23 2024 at 12:05 UTC