Stream: git-wasmtime

Topic: wasmtime / PR #9702 Rely on `core::error::Error`

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2024 at 17:17):

alexcrichton opened PR #9702 from alexcrichton:core-error to bytecodealliance:main:

With Wasmtime's new MSRV at 1.81 this means that core::error::Error is available which means that in no_std mode the Error trait can be used. This has been integrated into anyhow::Error already upstream and means that we can remove our own local hacks such as the Err2Anyhow trait.

This commit removes the Err2Anyhow trait and all usage, going back to idiomatic Rust error propagation and conversion even in the no_std world. This should make code more portable by default and remove some weird idioms we had for supporting this.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2024 at 17:18):

alexcrichton commented on PR #9702:

I'll note that this is a draft as this depends on a few upstream PRs:

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2024 at 18:13):

alexcrichton updated PR #9702.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2024 at 18:35):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2024 at 19:44):

github-actions[bot] commented on PR #9702:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:ref-types"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2024 at 23:20):

alexcrichton updated PR #9702.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2024 at 23:20):

alexcrichton has marked PR #9702 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2024 at 23:20):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9702.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2024 at 23:20):

alexcrichton requested abrown for a review on PR #9702.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2024 at 23:20):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9702.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2024 at 23:21):

alexcrichton commented on PR #9702:

Ok everything's good to go except object. I've also added an update of anyhow and serde to pull in their latest versions which have support for core::error::Error. A small workaround for object::Error has been added temporarily which can be removed once the upstream PR is merged and/or the feature is settled one way or another.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2024 at 23:28):

alexcrichton updated PR #9702.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2024 at 23:28):

alexcrichton has enabled auto merge for PR #9702.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2024 at 01:13):

alexcrichton updated PR #9702.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2024 at 16:56):

alexcrichton updated PR #9702.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2024 at 17:08):

alexcrichton updated PR #9702.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2024 at 17:16):

alexcrichton updated PR #9702.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2024 at 17:24):

alexcrichton updated PR #9702.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2024 at 17:31):

alexcrichton updated PR #9702.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2024 at 17:48):

alexcrichton updated PR #9702.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2024 at 17:55):

alexcrichton updated PR #9702.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2024 at 18:01):

alexcrichton updated PR #9702.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2024 at 18:10):

alexcrichton updated PR #9702.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2024 at 18:12):

alexcrichton commented on PR #9702:

Ok through much trial and error I've discovered that the s390x-specific failure on CI with this PR is due to the anyhow update. That's specifically the 1.0.76 to 1.0.77 update (which we're jumping from 75 to 93 here). This update uses std::backtrace by default and respects RUST_BACKTRACE=1. For the longest time I couldn't reproduce this locally, and turns out I copied over all env vars in CI except RUST_BACKTRACE=1.

I've disabled backtraces in CI for now. If that works and this lands I'll file an issue and cc Ulrich.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2024 at 18:45):

alexcrichton merged PR #9702.

Last updated: Dec 23 2024 at 13:07 UTC