Stream: git-wasmtime

Topic: wasmtime / PR #9700 [DWARF] Synthetic type centralization

Wasmtime GitHub notifications bot (Dec 01 2024 at 21:10):

SingleAccretion edited PR #9700.

Wasmtime GitHub notifications bot (Dec 01 2024 at 21:22):

SingleAccretion has marked PR #9700 as ready for review.

Wasmtime GitHub notifications bot (Dec 01 2024 at 21:23):

SingleAccretion requested alexcrichton for a review on PR #9700.

Wasmtime GitHub notifications bot (Dec 01 2024 at 21:23):

SingleAccretion requested wasmtime-core-reviewers for a review on PR #9700.

Wasmtime GitHub notifications bot (Dec 01 2024 at 21:40):

SingleAccretion edited PR #9700:

The DWARF transform needs to add some "synthetic" types to the output, mainly to represent the VMContext structure.

So far, these types were being added to each CU, which is unnecessary overhead since they're exactly the same in each CU in a given module.

This change moves them to a single per-module CU that is references via DWARF's DW_FORM_ref_addr mechanism.

This is an optimization in both time (the debugger needs fewer types to keep track of) and space (the .debug_info section ~5% smaller on some DWARF input I have).

Wasmtime GitHub notifications bot (Dec 01 2024 at 21:40):

SingleAccretion edited PR #9700:

The DWARF transform needs to add some "synthetic" types to the output, mainly to represent the VMContext structure.

So far, these types were being added to each CU, which is unnecessary overhead since they're exactly the same in each CU in a given module.

This change moves them to a single per-module CU that is references via DWARF's DW_FORM_ref_addr mechanism.

This is an optimization in both time (the debugger needs fewer types to keep track of) and space (the .debug_info section is ~5% smaller on some DWARF input I have).

Wasmtime GitHub notifications bot (Dec 02 2024 at 15:32):

alexcrichton submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Dec 02 2024 at 15:49):

alexcrichton merged PR #9700.

Last updated: Dec 23 2024 at 12:05 UTC