Wasmtime GitHub notifications bot (Nov 29 2024 at 02:00): Wasmtime GitHub notifications bot (Nov 29 2024 at 02:00):alexcrichton opened PR #9693 from alexcrichton:no-enumerate to bytecodealliance:main:
I'm doing some other refactoring which makes it a pain to maintain a list in two locations of what all the host signatures are. Instead remove the pulley
for_each_host_signature!macro entirely. My thinking is to instead implement a different system for host calls in pulley:
- The same relocation-style mechanism is used with some number-embedded-in-the-bytecode.
- The interpreter exits with "imma call the host" when it sees this special opcode.
- The interpreter embedder, aka Wasmtime, is responsible for then invoking the actual function pointer.
- Wasmtime already has static knowledge of all its function signatures, e.g. via various macros.
This will prevent the need to list all function signatures twice and risk them getting out of sync. Most of the Pulley-level integration work here is left to a future commit.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 29 2024 at 02:00):alexcrichton has marked PR #9693 as ready for review.
Wasmtime GitHub notifications bot (Nov 29 2024 at 02:00):alexcrichton requested wasmtime-core-reviewers for a review on PR #9693.
Wasmtime GitHub notifications bot (Nov 29 2024 at 02:00):alexcrichton requested pchickey for a review on PR #9693.
Wasmtime GitHub notifications bot (Nov 29 2024 at 02:00):alexcrichton requested wasmtime-default-reviewers for a review on PR #9693.
Wasmtime GitHub notifications bot (Nov 29 2024 at 03:03):github-actions[bot] commented on PR #9693:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "pulley"Thus the following users have been cc'd because of the following labels:
- fitzgen: pulley
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Dec 02 2024 at 19:02):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Dec 02 2024 at 20:48):alexcrichton merged PR #9693.
Last updated: Dec 23 2024 at 13:07 UTC