Stream: git-wasmtime

Topic: wasmtime / PR #9687 Move MemoryImageSource::map_at to mma...

Wasmtime GitHub notifications bot (Dec 06 2024 at 22:45):

sunshowers edited PR #9687.

Wasmtime GitHub notifications bot (Dec 06 2024 at 22:47):

sunshowers updated PR #9687.

Wasmtime GitHub notifications bot (Dec 06 2024 at 22:47):

sunshowers edited PR #9687:

This is part of the work to centralize memory management into the mmap
module. This commit introduces a few structures which aid in that process, and
starts converting one of the functions (MemoryImageSource::map_at) into this
module.

The structures introduced are:

• MemoryBase: RuntimeLinearMemory::base_ptr is now
  RuntimeLinearMemory::base, which returns a MemoryBase. This is either a
  raw pointer or an MmapOffset as described below.

• MmapOffset: A combination of a reference to an mmap and an offset into it.
  Logically represents a pointer into a mapped section of memory.

In future work, we'll move more image-mapping code over to Mmap instances.

Wasmtime GitHub notifications bot (Dec 06 2024 at 22:54):

sunshowers submitted PR review.

Wasmtime GitHub notifications bot (Dec 06 2024 at 22:54):

sunshowers created PR review comment:

Oh, and adding a Drop impl identified the problem with unwrap_static_image, haha, since you can't move out of a type when there's a Drop impl.

Wasmtime GitHub notifications bot (Dec 06 2024 at 23:06):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Dec 06 2024 at 23:06):

alexcrichton created PR review comment:

Ah ok that all makes sense to me yeah, thanks for checking!

Wasmtime GitHub notifications bot (Dec 06 2024 at 23:30):

sunshowers commented on PR #9687:

Fixing the issues

Wasmtime GitHub notifications bot (Dec 06 2024 at 23:34):

sunshowers updated PR #9687.

Wasmtime GitHub notifications bot (Dec 06 2024 at 23:36):

sunshowers commented on PR #9687:

Hmm, actually I want to rename the os-specific Mmap as_ptr instances.

Wasmtime GitHub notifications bot (Dec 06 2024 at 23:40):

sunshowers updated PR #9687.

Wasmtime GitHub notifications bot (Dec 06 2024 at 23:41):

sunshowers submitted PR review.

Wasmtime GitHub notifications bot (Dec 06 2024 at 23:41):

sunshowers created PR review comment:

Changed some of this code's pointer typology (though not the arithmetic) -- would be worth a look.

Wasmtime GitHub notifications bot (Dec 07 2024 at 00:07):

alexcrichton merged PR #9687.

Last updated: Dec 23 2024 at 12:05 UTC