Wasmtime GitHub notifications bot (Nov 25 2024 at 20:15): Wasmtime GitHub notifications bot (Nov 25 2024 at 20:15):alexcrichton requested pchickey for a review on PR #9677.
Wasmtime GitHub notifications bot (Nov 25 2024 at 20:15):alexcrichton opened PR #9677 from alexcrichton:use-non-null-more to bytecodealliance:main:
This commit switches to using
NonNull<VMFuncRef>in more places instead of*mut VMFuncRef. A few minor locations benefitted from this by removing some otherwise extraneous checks but most places have been updated to mostly do the same as before. The goal of this commit is to make it more clear about what returns a nullable reference and what never returns a nullable reference. Additionally some constructors now unconditionally work withNonNull<T>instead of checking for null internally.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 25 2024 at 20:15):alexcrichton requested wasmtime-core-reviewers for a review on PR #9677.
Wasmtime GitHub notifications bot (Nov 25 2024 at 21:44):github-actions[bot] commented on PR #9677:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
- fitzgen: wasmtime:ref-types
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Nov 25 2024 at 23:01):alexcrichton updated PR #9677.
Wasmtime GitHub notifications bot (Nov 26 2024 at 01:47):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Nov 26 2024 at 03:25):alexcrichton merged PR #9677.
Last updated: Dec 23 2024 at 12:05 UTC