Stream: git-wasmtime

Topic: wasmtime / PR #9673 Simplify some trap handling in `wasmt...

Wasmtime GitHub notifications bot (Nov 25 2024 at 16:05):

alexcrichton requested pchickey for a review on PR #9673.

Wasmtime GitHub notifications bot (Nov 25 2024 at 16:05):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9673.

Wasmtime GitHub notifications bot (Nov 25 2024 at 16:05):

alexcrichton opened PR #9673 from alexcrichton:simplify-traps to bytecodealliance:main:

The needs_backtrace field on TrapReason is an old artifact of having the wasmtime and wasmtime-runtime crates split and there's no longer any need for that. This commit removes the field and directly queries it from the error as necessary when capturing backtraces.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 25 2024 at 18:48):

pchickey submitted PR review:

:prohibited: :spaghetti:

Wasmtime GitHub notifications bot (Nov 25 2024 at 19:17):

alexcrichton merged PR #9673.

Last updated: Dec 23 2024 at 12:05 UTC