Stream: git-wasmtime

Topic: wasmtime / PR #9662 pulley: Don't test hexdumps by default


view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2024 at 20:58):

alexcrichton requested cfallin for a review on PR #9662.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2024 at 20:58):

alexcrichton opened PR #9662 from alexcrichton:pulley-no-test-hex to bytecodealliance:main:

These are brittle tests as we add/remove opcodes so minimize the number of tests that are doing this. This is already exposed through other testing like in Cranelift or disas testing, so don't have any manually-updated tests with hex dumps.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2024 at 20:58):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9662.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2024 at 21:01):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2024 at 21:01):

cfallin has enabled auto merge for PR #9662.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2024 at 21:32):

cfallin merged PR #9662.


Last updated: Dec 23 2024 at 12:05 UTC