Stream: git-wasmtime

Topic: wasmtime / PR #9652 move most of runtime/vm/cow.rs over t...

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2024 at 06:09):

sunshowers opened PR #9652 from sunshowers:cow-aligned to bytecodealliance:main:

As part of attempting to move some of these operations over to Mmap instances, it is nice to have type-level checking for aligned sizes. In upcoming PRs, APIs like map_at will be switched to using Mmap instances with aligned counts.

There are a couple of spots where I have questions -- will flag them in review comments.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2024 at 06:09):

sunshowers requested alexcrichton for a review on PR #9652.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2024 at 06:09):

sunshowers requested wasmtime-core-reviewers for a review on PR #9652.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2024 at 06:10):

sunshowers submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2024 at 06:10):

sunshowers created PR review comment:

Thoughts about this? I tried to be super cautious about signs this time.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2024 at 06:10):

sunshowers created PR review comment:

Wasn't clear to me whether this was possible -- there are several offsets here that all interact with each other.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2024 at 06:12):

sunshowers updated PR #9652.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2024 at 06:18):

sunshowers edited PR review comment.

Last updated: Nov 22 2024 at 17:03 UTC