Stream: git-wasmtime

Topic: wasmtime / PR #9644 pulley: Fix interpreter push/pop

Wasmtime GitHub notifications bot (Nov 21 2024 at 02:25):

alexcrichton opened PR #9644 from alexcrichton:fix-pulley-push-pop to bytecodealliance:main:

• Add stack-overflow checking to push and other decrements of sp.
• Fix the up/down direction of push/pop (push goes down, pop goes up).
• Fix the order of operation sin push, first decrement then write.
• Move methods to Interpreter to use ControlFlow more heavily.

Wasmtime GitHub notifications bot (Nov 21 2024 at 02:25):

alexcrichton requested cfallin for a review on PR #9644.

Wasmtime GitHub notifications bot (Nov 21 2024 at 02:25):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9644.

Wasmtime GitHub notifications bot (Nov 21 2024 at 02:25):

alexcrichton commented on PR #9644:

Review-wise this is stacked on https://github.com/bytecodealliance/wasmtime/pull/9629

Wasmtime GitHub notifications bot (Nov 21 2024 at 03:48):

github-actions[bot] commented on PR #9644:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "pulley"

Thus the following users have been cc'd because of the following labels:

• fitzgen: pulley

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Nov 22 2024 at 19:51):

alexcrichton updated PR #9644.

Wasmtime GitHub notifications bot (Nov 22 2024 at 19:51):

alexcrichton commented on PR #9644:

rebased!

Wasmtime GitHub notifications bot (Nov 25 2024 at 23:32):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Nov 25 2024 at 23:32):

abrown created PR review comment:

I guess MachineState::with_stack already does that but Pulley was just incorrectly pushing and popping?

Wasmtime GitHub notifications bot (Nov 25 2024 at 23:32):

abrown created PR review comment:

If we're switching the direction of growth, is there something that needs to be done to flip where sp starts at when we create the interpreter state?

Wasmtime GitHub notifications bot (Nov 26 2024 at 00:33):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 26 2024 at 00:33):

alexcrichton created PR review comment:

Ah yeah I don't believe it was ever the intentional to reverse the order of the stack with respect to native stacks, so I believe this was just a copy/paste error. (you can tell we don't run the interpreter much right now)

Wasmtime GitHub notifications bot (Nov 26 2024 at 00:50):

alexcrichton merged PR #9644.

Last updated: Dec 23 2024 at 13:07 UTC