Stream: git-wasmtime

Topic: wasmtime / PR #9644 pulley: Fix interpreter push/pop

Wasmtime GitHub notifications bot (Nov 21 2024 at 02:25):

alexcrichton opened PR #9644 from alexcrichton:fix-pulley-push-pop to bytecodealliance:main:

• Add stack-overflow checking to push and other decrements of sp.
• Fix the up/down direction of push/pop (push goes down, pop goes up).
• Fix the order of operation sin push, first decrement then write.
• Move methods to Interpreter to use ControlFlow more heavily.

Wasmtime GitHub notifications bot (Nov 21 2024 at 02:25):

alexcrichton requested cfallin for a review on PR #9644.

Wasmtime GitHub notifications bot (Nov 21 2024 at 02:25):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9644.

Wasmtime GitHub notifications bot (Nov 21 2024 at 02:25):

alexcrichton commented on PR #9644:

Review-wise this is stacked on https://github.com/bytecodealliance/wasmtime/pull/9629

Wasmtime GitHub notifications bot (Nov 21 2024 at 03:48):

github-actions[bot] commented on PR #9644:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "pulley"

Thus the following users have been cc'd because of the following labels:

• fitzgen: pulley

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Last updated: Nov 22 2024 at 16:03 UTC