Wasmtime GitHub notifications bot (Nov 20 2024 at 23:37): Wasmtime GitHub notifications bot (Nov 20 2024 at 23:37):alexcrichton opened PR #9640 from alexcrichton:change-builtin-conv to bytecodealliance:main:
This commit updates how Cranelift compiles the shims that go from WebAssembly to various libcall builtins (e.g.
memory.grow). Previously the small trampolines in Cranelift were compiled with the native host calling convention and this commit instead changes them to the wasm calling convention (e.g. "tail"). This helps keep caller/callee matched with calling conventions in wasm code itself and shifts the boundary of the wasm->host transition to the indirect call of the host function pointer itself. The general hope is that this makes Pulley a bit easier since it'll want to minimize handling of wasm->host transitions.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 20 2024 at 23:37):alexcrichton requested pchickey for a review on PR #9640.
Wasmtime GitHub notifications bot (Nov 20 2024 at 23:37):alexcrichton requested wasmtime-core-reviewers for a review on PR #9640.
Wasmtime GitHub notifications bot (Nov 21 2024 at 01:26):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Nov 21 2024 at 16:10):alexcrichton updated PR #9640.
Wasmtime GitHub notifications bot (Nov 21 2024 at 16:10):alexcrichton has enabled auto merge for PR #9640.
Wasmtime GitHub notifications bot (Nov 21 2024 at 16:56):alexcrichton requested cfallin for a review on PR #9640.
Wasmtime GitHub notifications bot (Nov 21 2024 at 16:56):alexcrichton updated PR #9640.
Wasmtime GitHub notifications bot (Nov 21 2024 at 16:56):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9640.
Wasmtime GitHub notifications bot (Nov 21 2024 at 16:56):alexcrichton has enabled auto merge for PR #9640.
Wasmtime GitHub notifications bot (Nov 21 2024 at 17:23):alexcrichton merged PR #9640.
Last updated: Nov 22 2024 at 16:03 UTC