Wasmtime GitHub notifications bot (Nov 20 2024 at 20:13): Wasmtime GitHub notifications bot (Nov 20 2024 at 20:13):sunshowers opened PR #9639 from sunshowers:mmap-aligned to bytecodealliance:main:
In the wasmtime codebase there are two kinds of mmaps: those that are always backed by anonymous memory and are always aligned, and those that are possibly file-backed and so the length might be unaligned. In https://github.com/bytecodealliance/wasmtime/pull/9620 I accidentally mixed the two up in a way that was a ticking time bomb.
To resolve this, add a type parameter to
Mmapto distinguish between the cases. All of wasmtime's users are clearly either one or the other, so it's quite simple in the end.
Wasmtime GitHub notifications bot (Nov 20 2024 at 20:13):sunshowers requested alexcrichton for a review on PR #9639.
Wasmtime GitHub notifications bot (Nov 20 2024 at 20:13):sunshowers requested wasmtime-core-reviewers for a review on PR #9639.
Wasmtime GitHub notifications bot (Nov 20 2024 at 20:52):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Nov 20 2024 at 20:59):sunshowers submitted PR review.
Wasmtime GitHub notifications bot (Nov 20 2024 at 20:59):sunshowers created PR review comment:
whoops, will fix in the followup!
Wasmtime GitHub notifications bot (Nov 20 2024 at 21:11):alexcrichton merged PR #9639.
Wasmtime GitHub notifications bot (Nov 20 2024 at 22:50):sunshowers submitted PR review.
Wasmtime GitHub notifications bot (Nov 20 2024 at 22:50):sunshowers created PR review comment:
Included a fix in https://github.com/bytecodealliance/wasmtime/pull/9620.
Last updated: Dec 23 2024 at 12:05 UTC