Wasmtime GitHub notifications bot (Nov 20 2024 at 19:38): Wasmtime GitHub notifications bot (Nov 20 2024 at 19:38):alexcrichton opened PR #9638 from alexcrichton:opaque-pointer to bytecodealliance:main:
This pointer is technically not safe to be a function pointer because it will get unloaded when the module is dropped. Additionally with Pulley this isn't actually a native function pointer. This builds on #9630 to prepare for future integration with Pulley to ensure that the number of locations that have to deal with bytecode-vs-native-code are minimized.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 20 2024 at 19:38):alexcrichton requested pchickey for a review on PR #9638.
Wasmtime GitHub notifications bot (Nov 20 2024 at 19:38):alexcrichton requested wasmtime-core-reviewers for a review on PR #9638.
Wasmtime GitHub notifications bot (Nov 21 2024 at 02:28):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Nov 21 2024 at 03:05):alexcrichton merged PR #9638.
Last updated: Nov 22 2024 at 17:03 UTC