Stream: git-wasmtime

Topic: wasmtime / PR #9636 Speed up a "big stack" test by using ...


view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2024 at 18:30):

alexcrichton opened PR #9636 from alexcrichton:optimize-test to bytecodealliance:main:

This test currently takes 50s locally in debug mode locally so instead switch it to using Winch so it finishes much faster.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2024 at 18:30):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9636.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2024 at 18:30):

alexcrichton requested pchickey for a review on PR #9636.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2024 at 18:34):

pchickey submitted PR review:

Just to help me understand: does this mean we lose test coverage for cranelift? if we're not losing coverage, why does this test exist?

view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2024 at 18:38):

alexcrichton has enabled auto merge for PR #9636.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2024 at 18:38):

alexcrichton has disabled auto merge for PR #9636.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2024 at 18:56):

alexcrichton updated PR #9636.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2024 at 18:57):

alexcrichton commented on PR #9636:

A good question! I did a bit more digging and I've now changed this to:

That makes the test much speedier now so it will continue to test Cranelift.


Last updated: Dec 23 2024 at 12:05 UTC