Wasmtime GitHub notifications bot (Nov 20 2024 at 18:30): Wasmtime GitHub notifications bot (Nov 20 2024 at 18:30):alexcrichton opened PR #9636 from alexcrichton:optimize-test to bytecodealliance:main:
This test currently takes 50s locally in debug mode locally so instead switch it to using Winch so it finishes much faster.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 20 2024 at 18:30):alexcrichton requested wasmtime-core-reviewers for a review on PR #9636.
Wasmtime GitHub notifications bot (Nov 20 2024 at 18:30):alexcrichton requested pchickey for a review on PR #9636.
Wasmtime GitHub notifications bot (Nov 20 2024 at 18:34):pchickey submitted PR review:
Just to help me understand: does this mean we lose test coverage for cranelift? if we're not losing coverage, why does this test exist?
Wasmtime GitHub notifications bot (Nov 20 2024 at 18:38):alexcrichton has enabled auto merge for PR #9636.
Wasmtime GitHub notifications bot (Nov 20 2024 at 18:38):alexcrichton has disabled auto merge for PR #9636.
Wasmtime GitHub notifications bot (Nov 20 2024 at 18:56):alexcrichton updated PR #9636.
Wasmtime GitHub notifications bot (Nov 20 2024 at 18:57):alexcrichton commented on PR #9636:
A good question! I did a bit more digging and I've now changed this to:
- This is tested on both Winch and Cranelift now.
- Cranelift disables egraph optimizations
- Cranelift uses the single-pass register allocation pass
That makes the test much speedier now so it will continue to test Cranelift.
Last updated: Nov 22 2024 at 17:03 UTC