Stream: git-wasmtime

Topic: wasmtime / PR #9633 Cranelift: rework isle-in-source-tree...


view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2024 at 17:20):

cfallin requested abrown for a review on PR #9633.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2024 at 17:20):

cfallin requested wasmtime-compiler-reviewers for a review on PR #9633.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2024 at 17:20):

cfallin opened PR #9633 from cfallin:cranelift-isle-source-tree to bytecodealliance:main:

Per #9625 and #9588, a downstream user of Cranelift was misusing the isle-in-source-tree feature, enabling it indiscriminately even in published crates (wasmerio/wasmer#5202). This went against the intent of the feature, to be a way for local developers to observe the generated source. As such, it ran afoul of some safety checks for that purpose, and also polluted users' Cargo caches in a way that we cannot now fix except in future releases.

The best we can do is probably to take away features that are liable to be misused. Following discussion in today's Cranelift weekly meeting, we decided to provide this functionality under an environment variable instead. This allows folks who know what they're doing to get the same behavior, but does not expose a feature to crate users.

Fixes #9625.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2024 at 17:22):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2024 at 17:26):

cfallin has enabled auto merge for PR #9633.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2024 at 17:40):

cfallin commented on PR #9633:

I think the merge queue run raced with the release; cargo-vet failed because it found a version on crates.io it didn't expect. Re-running, but noting in case we see it again later -- interesting corner case!

view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2024 at 17:44):

alexcrichton commented on PR #9633:

Ah I don't think this is spurious but should be fixed at https://github.com/bytecodealliance/wasmtime/pull/9635

view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2024 at 18:15):

alexcrichton merged PR #9633.


Last updated: Dec 23 2024 at 12:05 UTC