Stream: git-wasmtime

Topic: wasmtime / PR #9627 Refactor the `#[wasmtime_test]` macro

Wasmtime GitHub notifications bot (Nov 20 2024 at 15:53):

alexcrichton requested wasmtime-fuzz-reviewers for a review on PR #9627.

Wasmtime GitHub notifications bot (Nov 20 2024 at 15:53):

alexcrichton opened PR #9627 from alexcrichton:refactor-wasmtime-test to bytecodealliance:main:

• Start tests with a blank slate of features instead of with the default set of features enables (ensures each test explicitly specifies required features)

• Reuse test features from wasmtime_wast_util to avoid duplicating listings of features. Also shares logic for "should this compiler fail this test because of unsupported features".

• Move logic in tests/wast.rs to apply test configuration to a Config to a new location that can be shared across suites.

• Add a new feature for simd and flag tests that need it with the feature.

This is done in preparation for adding a new compiler strategy of Pulley to be able to flag tests as passing for pulley or not.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 20 2024 at 15:53):

alexcrichton requested pchickey for a review on PR #9627.

Wasmtime GitHub notifications bot (Nov 20 2024 at 15:53):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9627.

Wasmtime GitHub notifications bot (Nov 20 2024 at 15:53):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9627.

Wasmtime GitHub notifications bot (Nov 20 2024 at 17:41):

abrown created PR review comment:

Maybe this should be #[should_panic]? I get that this keeps the original behavior but more just wondering: if we check for panics and then it stops panicking then we know more quickly which Winch tests can be enabled.

Wasmtime GitHub notifications bot (Nov 20 2024 at 17:41):

abrown submitted PR review:

This improvement looks good!

Wasmtime GitHub notifications bot (Nov 20 2024 at 18:47):

github-actions[bot] commented on PR #9627:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "fuzzing"

Thus the following users have been cc'd because of the following labels:

• fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Nov 20 2024 at 19:04):

alexcrichton updated PR #9627.

Wasmtime GitHub notifications bot (Nov 20 2024 at 19:05):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 20 2024 at 19:05):

alexcrichton created PR review comment:

Good point! Works well :+1:

Wasmtime GitHub notifications bot (Nov 20 2024 at 19:05):

alexcrichton has enabled auto merge for PR #9627.

Wasmtime GitHub notifications bot (Nov 20 2024 at 19:41):

alexcrichton merged PR #9627.

Last updated: Dec 23 2024 at 12:05 UTC