Wasmtime GitHub notifications bot (Nov 20 2024 at 10:14): Wasmtime GitHub notifications bot (Nov 20 2024 at 10:14):iii-i requested wasmtime-core-reviewers for a review on PR #9626.
Wasmtime GitHub notifications bot (Nov 20 2024 at 10:14):iii-i requested alexcrichton for a review on PR #9626.
Wasmtime GitHub notifications bot (Nov 20 2024 at 10:15):iii-i opened PR #9626 from iii-i:skip-the-rlimited-memory-test-under-qemu to bytecodealliance:main:
After the rework of the QEMU memory management, which landed in v8.0.0 and introduced interval trees instead of individual page descriptors - similar to how the Linux kernel does it - it became possible to run the WASMTIME_TEST_NO_HOG_MEMORY tests under it.
The only exception is the rlimited-memory test, which relies on the underlying OS enforcing the RLIMIT_DATA limit. QEMU chose to ignore this limit, because it interferes with its JIT.
Skip this test when using emulation.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 20 2024 at 16:07):alexcrichton submitted PR review:
Thanks!
Wasmtime GitHub notifications bot (Nov 20 2024 at 16:25):alexcrichton merged PR #9626.
Last updated: Nov 22 2024 at 17:03 UTC