Stream: git-wasmtime

Topic: wasmtime / PR #9623 Remove feature validation from Wasmtime

Wasmtime GitHub notifications bot (Nov 19 2024 at 17:40):

alexcrichton requested pchickey for a review on PR #9623.

Wasmtime GitHub notifications bot (Nov 19 2024 at 17:40):

alexcrichton opened PR #9623 from alexcrichton:remove-feature-validation to bytecodealliance:main:

Some of this originated in #917 but nowadays it shouldn't be necessary to control proposals like this. Instead it's probably best nowadays to throw configuration at wasmparser and use its definition of features to determine whether constructs make sense or not. This reduces the amount of bits and pieces Wasmtime has to do and avoids interactions such as #9622.

Closes #9622

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 19 2024 at 17:40):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9623.

Wasmtime GitHub notifications bot (Nov 19 2024 at 17:47):

nagisa submitted PR review.

Wasmtime GitHub notifications bot (Nov 19 2024 at 18:04):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Nov 19 2024 at 18:32):

alexcrichton merged PR #9623.

Last updated: Nov 22 2024 at 16:03 UTC