Wasmtime GitHub notifications bot (Nov 16 2024 at 13:52): Wasmtime GitHub notifications bot (Nov 16 2024 at 13:52):alexcrichton opened PR #9614 from alexcrichton:traps-cargo-feature to bytecodealliance:main:
This PR adds a new
signals-based-trapsCargo compile-time feature which mirrors theConfig::signals_based_trapsruntime configuration. Disabling this Cargo feature enables reducing Wasmtime's platform requirements to remove the need for virtual memory and trap handlers for example. That means that the underlying platform requirements are just setjmp/longjmp and a single pointer of thread-local storage. This should make it significantly easier to port Wasmtime to platforms that may not have virtual memory in the future.I'll note that one of the main purposes of this PR isn't quite realized just yet which is to run Pulley on embedded systems. Pulley isn't finished, however, so this is more setting the stage for that to be possible in the future than enabling it right this red-hot-second.
Wasmtime GitHub notifications bot (Nov 16 2024 at 14:00):alexcrichton updated PR #9614.
Wasmtime GitHub notifications bot (Nov 16 2024 at 14:09):alexcrichton updated PR #9614.
Wasmtime GitHub notifications bot (Nov 16 2024 at 14:10):alexcrichton updated PR #9614.
Wasmtime GitHub notifications bot (Nov 16 2024 at 15:44):github-actions[bot] commented on PR #9614:
Label Messager: wasmtime:config
It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:
[ ] If you added a new
Configmethod, you wrote extensive documentation for
it.<details>
Our documentation should be of the following form:
```text
Short, simple summary sentence.More details. These details can be multiple paragraphs. There should be
information about not just the method, but its parameters and results as
well.Is this method fallible? If so, when can it return an error?
Can this method panic? If so, when does it panic?
Example
Optional example here.
```</details>
[ ] If you added a new
Configmethod, or modified an existing one, you
ensured that this configuration is exercised by the fuzz targets.<details>
For example, if you expose a new strategy for allocating the next instance
slot inside the pooling allocator, you should ensure that at least one of our
fuzz targets exercises that new strategy.Often, all that is required of you is to ensure that there is a knob for this
configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
of its nestedstructs).Rarely, this may require authoring a new fuzz target to specifically test this
configuration. See [our docs on fuzzing][fuzzing-docs] for more details.</details>
[ ] If you are enabling a configuration option by default, make sure that it
has been fuzzed for at least two weeks before turning it on by default.[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html
<details>
To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.
To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.</details>
Wasmtime GitHub notifications bot (Nov 16 2024 at 17:50):alexcrichton updated PR #9614.
Wasmtime GitHub notifications bot (Nov 16 2024 at 17:53):alexcrichton updated PR #9614.
Wasmtime GitHub notifications bot (Nov 16 2024 at 19:44):github-actions[bot] commented on PR #9614:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "fuzzing", "wasi", "wasmtime:api", "wasmtime:config"Thus the following users have been cc'd because of the following labels:
- fitzgen: fuzzing
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Nov 16 2024 at 19:52):alexcrichton updated PR #9614.
Wasmtime GitHub notifications bot (Nov 17 2024 at 11:26):bjorn3 created PR review comment:
Maybe make this the default when std is enabled? It seems highly unintuitive that disabling say the gc feature using
default-features = falsewould silently reduce performance.
Wasmtime GitHub notifications bot (Nov 17 2024 at 11:26):bjorn3 submitted PR review.
Wasmtime GitHub notifications bot (Nov 17 2024 at 11:27):bjorn3 edited PR review comment.
Wasmtime GitHub notifications bot (Nov 18 2024 at 16:56):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Nov 18 2024 at 16:56):alexcrichton created PR review comment:
Agreed yeah, I added that in bb8fa843139ac84247e0883908a9da429ef5b7d5
Wasmtime GitHub notifications bot (Nov 18 2024 at 17:11):alexcrichton has marked PR #9614 as ready for review.
Wasmtime GitHub notifications bot (Nov 18 2024 at 17:11):alexcrichton requested wasmtime-fuzz-reviewers for a review on PR #9614.
Wasmtime GitHub notifications bot (Nov 18 2024 at 17:11):alexcrichton requested pchickey for a review on PR #9614.
Wasmtime GitHub notifications bot (Nov 18 2024 at 17:11):alexcrichton requested wasmtime-core-reviewers for a review on PR #9614.
Wasmtime GitHub notifications bot (Nov 18 2024 at 17:11):alexcrichton requested wasmtime-default-reviewers for a review on PR #9614.
Wasmtime GitHub notifications bot (Nov 18 2024 at 18:10):alexcrichton closed without merge PR #9614.
Wasmtime GitHub notifications bot (Nov 18 2024 at 18:10):alexcrichton updated PR #9614.
Wasmtime GitHub notifications bot (Nov 18 2024 at 18:10):alexcrichton reopened PR #9614.
Wasmtime GitHub notifications bot (Nov 18 2024 at 21:02):alexcrichton updated PR #9614.
Wasmtime GitHub notifications bot (Nov 18 2024 at 21:33):pchickey submitted PR review:
Pretty cool!
Wasmtime GitHub notifications bot (Nov 18 2024 at 21:33):pchickey created PR review comment:
TODO
Wasmtime GitHub notifications bot (Nov 19 2024 at 19:01):alexcrichton updated PR #9614.
Wasmtime GitHub notifications bot (Nov 19 2024 at 19:01):alexcrichton commented on PR #9614:
I've pushed some extra refactoring of
MmapVecas well to handle the internals a bit better given today's requirements.
Wasmtime GitHub notifications bot (Nov 19 2024 at 19:02):alexcrichton has enabled auto merge for PR #9614.
Wasmtime GitHub notifications bot (Nov 19 2024 at 19:44):alexcrichton merged PR #9614.
Last updated: Nov 22 2024 at 16:03 UTC