Stream: git-wasmtime

Topic: wasmtime / PR #9597 Fix typo from #9545

view this post on Zulip Wasmtime GitHub notifications bot (Nov 12 2024 at 16:38):

jder requested fitzgen for a review on PR #9597.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 12 2024 at 16:38):

jder requested wasmtime-core-reviewers for a review on PR #9597.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 12 2024 at 16:38):

jder opened PR #9597 from jder:memory-reservation-typo to bytecodealliance:main:

While trying to update wasmtime-py to use the latest dev version, I noticed what I think is just a typo causing a mismatch between the c header file:

WASMTIME_CONFIG_PROP(void, memory_reservation_for_growth, uint64_t)

which expands to wasmtime_config_memory_reservation_for_growth_set and this line (which still has "reserved"). I think just a typo from #9545.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 12 2024 at 17:10):

alexcrichton submitted PR review:

Oops, thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Nov 12 2024 at 17:30):

alexcrichton merged PR #9597.

Last updated: Dec 23 2024 at 12:05 UTC