Stream: git-wasmtime

Topic: wasmtime / PR #9587 Improve fuzzing of `*.wast` tests

Wasmtime GitHub notifications bot (Nov 09 2024 at 01:13):

alexcrichton opened PR #9587 from alexcrichton:fuzz-more-wast to bytecodealliance:main:

Currently we have a fuzzer which is tasked with running *.wast tests with fuzz-generated configurations. This asserts that we at least satisfy all basic wasm semantics regardless of how various knobs in Config are turned (modulo limits to resources). The current fuzzing though is not comprehensive in that it doesn't include all the spec tests that we pass from all proposals. This runs the risk of we don't actually fuzz anything until the spec tests are merged upstream, which can take a significant amount of time.

This commit refactors the *.wast-management infrastructure to share test discovery and feature calculation between tests/wast.rs and fuzzing. This new support crate centralizes limits and discovery for both to use. Additionally fuzzing is updated to no longer throw out test cases if configuration isn't applicable but instead clamp configuration to the minimum required values (e.g. features + resource limits). This means that we should now be fuzzing all spec tests that pass in all configurations.

This new fuzzer discovered a few minor issues with the GC proposal implementation, for example, such as:

• Some instructions were translated using trapping methods directly on FunctionBuilder rather than FuncEnvironment meaning they didn't properly handle signals-based-traps configuration.

• Fuel handling for return_call_ref wasn't correct because it was accidentally omitted from the list of return-call instructions that need special treatment.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 09 2024 at 01:13):

alexcrichton requested fitzgen for a review on PR #9587.

Wasmtime GitHub notifications bot (Nov 09 2024 at 01:13):

alexcrichton requested wasmtime-fuzz-reviewers for a review on PR #9587.

Wasmtime GitHub notifications bot (Nov 09 2024 at 01:13):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9587.

Wasmtime GitHub notifications bot (Nov 09 2024 at 01:13):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9587.

Wasmtime GitHub notifications bot (Nov 09 2024 at 02:53):

github-actions[bot] commented on PR #9587:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "fuzzing", "wasmtime:ref-types"

Thus the following users have been cc'd because of the following labels:

• fitzgen: fuzzing, wasmtime:ref-types

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Nov 10 2024 at 15:52):

alexcrichton updated PR #9587.

Wasmtime GitHub notifications bot (Nov 11 2024 at 21:00):

fitzgen submitted PR review:

Nice!

Wasmtime GitHub notifications bot (Nov 11 2024 at 21:00):

fitzgen created PR review comment:

Thanks for catching this!

Wasmtime GitHub notifications bot (Nov 11 2024 at 21:17):

fitzgen merged PR #9587.

Last updated: Nov 22 2024 at 16:03 UTC