Stream: git-wasmtime

Topic: wasmtime / PR #9577 Refactor the internals of `vm::Memory...

Wasmtime GitHub notifications bot (Nov 06 2024 at 22:05):

alexcrichton requested fitzgen for a review on PR #9577.

Wasmtime GitHub notifications bot (Nov 06 2024 at 22:05):

alexcrichton opened PR #9577 from alexcrichton:simplify-memory to bytecodealliance:main:

This is a series of commits which have the end-goal of removing the RuntimeLinearMemory trait and replacing it with wasmtime::LinearMemory. In doing this though I wanted to simplify the trait to move more responsibilities up a layer so it's clearer what the safety contracts are and what exactly is required on behalf of embedders. This moves many of the responsibilities to a new LocalMemory type rather than having most of the functionality implemented through trait methods. This provides, for example, a vector of having CoW support in Wasmtime without supporting it through LinearMemory (or not officially at least).

Each commit here is probably best viewed one-at-a-time since this adds up to a number of changes but I've tried to keep things separated and have tests passing for each individual commit.

Fixes #9568

Wasmtime GitHub notifications bot (Nov 06 2024 at 22:05):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9577.

Wasmtime GitHub notifications bot (Nov 06 2024 at 22:22):

alexcrichton updated PR #9577.

Wasmtime GitHub notifications bot (Nov 06 2024 at 22:38):

alexcrichton requested wasmtime-fuzz-reviewers for a review on PR #9577.

Wasmtime GitHub notifications bot (Nov 06 2024 at 22:38):

alexcrichton updated PR #9577.

Wasmtime GitHub notifications bot (Nov 06 2024 at 22:47):

alexcrichton updated PR #9577.

Wasmtime GitHub notifications bot (Nov 07 2024 at 02:08):

github-actions[bot] commented on PR #9577:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "fuzzing", "wasmtime:api", "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

• fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Nov 07 2024 at 15:38):

alexcrichton updated PR #9577.

Wasmtime GitHub notifications bot (Nov 07 2024 at 18:15):

fitzgen submitted PR review:

Nice! One suggestion on the ascii diagram below, that's it.

Wasmtime GitHub notifications bot (Nov 07 2024 at 18:15):

fitzgen created PR review comment:

//! │ RuntimeLinearMemory ├─────────────┬───────────────┐
//! │                     │             │               │
//! └──────────┬──────────┘             │               │

Wasmtime GitHub notifications bot (Nov 07 2024 at 18:28):

alexcrichton updated PR #9577.

Wasmtime GitHub notifications bot (Nov 07 2024 at 18:28):

alexcrichton has enabled auto merge for PR #9577.

Wasmtime GitHub notifications bot (Nov 07 2024 at 19:18):

alexcrichton merged PR #9577.

Last updated: Dec 23 2024 at 12:05 UTC