Stream: git-wasmtime

Topic: wasmtime / PR #9576 Remove use of `MemoryStyle` when comp...


view this post on Zulip Wasmtime GitHub notifications bot (Nov 06 2024 at 19:54):

alexcrichton requested fitzgen for a review on PR #9576.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 06 2024 at 19:54):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9576.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 06 2024 at 19:54):

alexcrichton opened PR #9576 from alexcrichton:cranelift-no-memorystyle to bytecodealliance:main:

Instead read directly from tunables and MemoryType with new helper methods that can be shared between Cranelift, Winch, and the rest of the memory subsystem.

Note that this is intended to be a pure-refactoring change. The diff here is large-ish but it's mostly accounted for via code movement and indentation changes. The high-level changes made to the structure of the code are:

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Nov 06 2024 at 23:04):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 06 2024 at 23:04):

fitzgen created PR review comment:

If this sequence is not going to be a match anymore, could we do a sequence of ifs that return and then a final base case? I think in this particular case, where we have big comments explaining each case, it will be more clear:

// Big comment...
if cond() && foo <= bar {
    // ...
    return ...;
}

// Special case for when blah blah ....
if ... {
    // ...
    return ...
}

// Base case: ...
...
Reachable

view this post on Zulip Wasmtime GitHub notifications bot (Nov 07 2024 at 01:13):

alexcrichton updated PR #9576.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 07 2024 at 01:13):

alexcrichton has enabled auto merge for PR #9576.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 07 2024 at 01:39):

alexcrichton merged PR #9576.


Last updated: Nov 22 2024 at 16:03 UTC