Stream: git-wasmtime

Topic: wasmtime / PR #9575 x64: Improve lowering for conditional...

Wasmtime GitHub notifications bot (Nov 06 2024 at 19:33):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9575.

Wasmtime GitHub notifications bot (Nov 06 2024 at 19:33):

alexcrichton requested fitzgen for a review on PR #9575.

Wasmtime GitHub notifications bot (Nov 06 2024 at 19:34):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9575.

Wasmtime GitHub notifications bot (Nov 06 2024 at 19:34):

alexcrichton opened PR #9575 from alexcrichton:x64-conditional-traps to bytecodealliance:main:

This commit improves the lowering rules on x64 for conditional traps (e.g. trapz and trapnz) to include a special-case with icmp which enables removing some extra instructions by materializing a comparison result into a register.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 06 2024 at 22:43):

fitzgen submitted PR review:

Nice catch!

Wasmtime GitHub notifications bot (Nov 06 2024 at 22:59):

fitzgen merged PR #9575.

Last updated: Nov 22 2024 at 17:03 UTC