Stream: git-wasmtime

Topic: wasmtime / PR #9571 Add `Module::from_trusted_open_file`

view this post on Zulip Wasmtime GitHub notifications bot (Nov 06 2024 at 11:36):

adambratschikaye opened PR #9571 from adambratschikaye:abk/use-opened-file to bytecodealliance:main:

Add an API to deserialize a Module from an already opened file. This can be useful in situations where wasmtime is running in a sandboxed environment with limited access to the file system. Then another process can handle opening the files and passing them to wasmtime.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 06 2024 at 11:55):

adambratschikaye updated PR #9571.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 06 2024 at 12:02):

adambratschikaye updated PR #9571.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 06 2024 at 12:38):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 06 2024 at 12:38):

bjorn3 created PR review comment:

It is not clear to me if this argument needs to match the actual location of the file you pass in or not. Or what happens when it doesn't match.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 06 2024 at 13:33):

adambratschikaye submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 06 2024 at 13:33):

adambratschikaye created PR review comment:

Yeah I'm still cleaning things up a bit. It's there so that we can still use it when calling from from_trusted_file, but I think we can remove it from the public version of this one.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 06 2024 at 14:52):

adambratschikaye updated PR #9571.

Last updated: Nov 22 2024 at 16:03 UTC