Wasmtime GitHub notifications bot (Oct 31 2024 at 20:21): Wasmtime GitHub notifications bot (Oct 31 2024 at 20:21):alexcrichton opened PR #9533 from alexcrichton:fix-custom-page-sizes-and-pooling-and-cow to bytecodealliance:main:
This commit fixes a runtime error that happened with the pooling allocator when combined with the custom-page-sizes proposal. The bug that happened was that sizes flowing into the pooling allocator were no longer host-page-size-aligned which caused syscalls to return an error unexpectedly. This meant that situations which were supposed to work were in fact not working.
The fix in this commit is to page-align incoming sizes into the CoW-pieces of memory management. This is coupled with a few more assertions that the
accessiblefield is always page-aligned, as expected.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 31 2024 at 20:21):alexcrichton requested fitzgen for a review on PR #9533.
Wasmtime GitHub notifications bot (Oct 31 2024 at 20:21):alexcrichton requested wasmtime-core-reviewers for a review on PR #9533.
Wasmtime GitHub notifications bot (Oct 31 2024 at 21:03):alexcrichton updated PR #9533.
Wasmtime GitHub notifications bot (Nov 01 2024 at 17:39):fitzgen submitted PR review:
Thanks!
Wasmtime GitHub notifications bot (Nov 01 2024 at 17:39):fitzgen created PR review comment:
fn custom_page_sizes_reusing_same_slot() -> Result<()> {
Wasmtime GitHub notifications bot (Nov 01 2024 at 17:41):alexcrichton updated PR #9533.
Wasmtime GitHub notifications bot (Nov 01 2024 at 17:41):alexcrichton has enabled auto merge for PR #9533.
Wasmtime GitHub notifications bot (Nov 01 2024 at 18:13):alexcrichton updated PR #9533.
Wasmtime GitHub notifications bot (Nov 01 2024 at 18:13):alexcrichton has enabled auto merge for PR #9533.
Wasmtime GitHub notifications bot (Nov 01 2024 at 18:38):alexcrichton merged PR #9533.
Last updated: Dec 23 2024 at 12:05 UTC