Wasmtime GitHub notifications bot (Oct 31 2024 at 17:51): Wasmtime GitHub notifications bot (Oct 31 2024 at 17:51):alexcrichton opened PR #9531 from alexcrichton:remove-table-style to bytecodealliance:main:
This is a follow-up to #9530 to remove the
wasmtime_environ::TableStyletype. This type was added quite a long time ago for future-proofing other styles of tables but at this point it's simpler to remove the type as adding another style of table hasn't been on the "table" (heh) for quite some time. This intends to further the goal of #9530 of plumbingTunablescloser to where it's ready to avoid extra layers of abstraction between the configuration options and what is processing them.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 31 2024 at 17:51):alexcrichton requested abrown for a review on PR #9531.
Wasmtime GitHub notifications bot (Oct 31 2024 at 17:51):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9531.
Wasmtime GitHub notifications bot (Oct 31 2024 at 17:51):alexcrichton requested pchickey for a review on PR #9531.
Wasmtime GitHub notifications bot (Oct 31 2024 at 17:51):alexcrichton requested wasmtime-core-reviewers for a review on PR #9531.
Wasmtime GitHub notifications bot (Oct 31 2024 at 18:30):abrown submitted PR review:
Makes sense to me!
Wasmtime GitHub notifications bot (Oct 31 2024 at 18:46):abrown merged PR #9531.
Last updated: Nov 22 2024 at 16:03 UTC