Stream: git-wasmtime

Topic: wasmtime / PR #9530 Remove the `wasmtime_environ::TablePl...

Wasmtime GitHub notifications bot (Oct 31 2024 at 16:46):

alexcrichton opened PR #9530 from alexcrichton:remove-table-plan to bytecodealliance:main:

In my quest to simplify memory configuration and how things work internally in Wasmtime one thing I've identified to accomplish is the removal of the TablePlan and MemoryPlan types. These introduce an abstraction layer between table/memory implementations and Tunables and personally I find it simpler to directly reference Tunables and use that instead. The goal of this commit is to plumb Tunables closer to where it's directly read by removing the "indirection" through the *Plan types.

The TablePlan and MemoryPlan types are pervasively used throughout Wasmtime so instead of having one large commit delete everything this is instead a piecemeal approach to incrementally get towards the goal of removal. Here just TablePlan is removed and Tunables is plumbed in a few more places. I plan to also in the future remove TableStyle and MemoryStyle in favor of directly reading Tunables but that's left for a future commit. For now TableStyle persists and its usage is a bit odd in isolation but I plan to follow this up with the removal of TableStyle.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 31 2024 at 16:46):

alexcrichton requested cfallin for a review on PR #9530.

Wasmtime GitHub notifications bot (Oct 31 2024 at 16:46):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9530.

Wasmtime GitHub notifications bot (Oct 31 2024 at 16:46):

alexcrichton requested elliottt for a review on PR #9530.

Wasmtime GitHub notifications bot (Oct 31 2024 at 16:46):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9530.

Wasmtime GitHub notifications bot (Oct 31 2024 at 16:50):

alexcrichton updated PR #9530.

Wasmtime GitHub notifications bot (Oct 31 2024 at 17:05):

cfallin submitted PR review:

Looks great, thanks!

Wasmtime GitHub notifications bot (Oct 31 2024 at 17:28):

cfallin merged PR #9530.

Last updated: Dec 23 2024 at 12:05 UTC