Stream: git-wasmtime

Topic: wasmtime / PR #9522 emove scheme booleans

view this post on Zulip Wasmtime GitHub notifications bot (Oct 30 2024 at 14:55):

Kmeakin opened PR #9522 from Kmeakin:km/isle/remove-scheme-booleans to bytecodealliance:main:

The `#t` and `#f` syntax is misleading: they are actually integer
expressions, not booleans, so `#t` represents the integer `1` but *not*
the boolean `true`. They have also been replaced by the named constants
`$true` and `$false`, and not used anywhere except tests, so they can be
removed without breaking any lowering/optimization code.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 30 2024 at 14:55):

Kmeakin requested abrown for a review on PR #9522.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 30 2024 at 14:55):

Kmeakin requested wasmtime-compiler-reviewers for a review on PR #9522.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 30 2024 at 14:55):

Kmeakin edited PR #9522:

The #t and #f syntax is misleading: they are actually expressions, not booleans, so #t represents the integer 1 but not the boolean true. They have been replaced by the named constants $true and $false, and not used anywhere except tests, so they can be removed without breaking any lowering/optimization code.

Last updated: Dec 23 2024 at 12:05 UTC