Stream: git-wasmtime

Topic: wasmtime / PR #9517 ISLE: update language reference


view this post on Zulip Wasmtime GitHub notifications bot (Oct 29 2024 at 13:10):

Kmeakin opened PR #9517 from Kmeakin:km/isle/language-reference to bytecodealliance:main:

The language specified in language-reference.md and the language recognised by parser.rs had drifted out of sync. Update the language reference to match the actual language more closely.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 29 2024 at 13:10):

Kmeakin requested cfallin for a review on PR #9517.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 29 2024 at 13:10):

Kmeakin requested wasmtime-compiler-reviewers for a review on PR #9517.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 29 2024 at 15:45):

github-actions[bot] commented on PR #9517:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Oct 29 2024 at 16:08):

cfallin submitted PR review:

Thanks! Generally I'm fine with extending the grammar to cover the new stuff; cc @avanhatt for thoughts on documenting this and if/how we want to add more info as well (or perhaps a pointer to the project/paper at least?).

view this post on Zulip Wasmtime GitHub notifications bot (Oct 29 2024 at 16:08):

cfallin created PR review comment:

Can we put these four in a separate <veri-def> production? In general we haven't documented the verification extensions to ISLE as they're somewhat still in flux; I want to try to keep them separate so as not to confuse users getting started.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 29 2024 at 16:08):

cfallin created PR review comment:

Likewise down here -- let's put all of these in a separate subsection of the grammar, maybe headlined by # ---- verification extensions ---- or something like that?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 30 2024 at 00:48):

Kmeakin updated PR #9517.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 30 2024 at 14:49):

Kmeakin updated PR #9517.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 30 2024 at 14:49):

Kmeakin updated PR #9517.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 30 2024 at 15:22):

cfallin submitted PR review:

Updates LGTM; final signoff from @avanhatt or @mmcloughlin would be great to verify this (thanks!).

view this post on Zulip Wasmtime GitHub notifications bot (Oct 30 2024 at 15:32):

Kmeakin updated PR #9517.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 31 2024 at 19:51):

Kmeakin updated PR #9517.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2024 at 00:04):

avanhatt submitted PR review:

This looks good to me, too, thanks for updating this doc!

view this post on Zulip Wasmtime GitHub notifications bot (Nov 04 2024 at 19:30):

cfallin merged PR #9517.


Last updated: Dec 23 2024 at 12:05 UTC