Wasmtime GitHub notifications bot (Oct 29 2024 at 13:10): Wasmtime GitHub notifications bot (Oct 29 2024 at 13:10):Kmeakin opened PR #9517 from Kmeakin:km/isle/language-reference to bytecodealliance:main:
The language specified in
language-reference.mdand the language recognised byparser.rshad drifted out of sync. Update the language reference to match the actual language more closely.
Wasmtime GitHub notifications bot (Oct 29 2024 at 13:10):Kmeakin requested cfallin for a review on PR #9517.
Wasmtime GitHub notifications bot (Oct 29 2024 at 13:10):Kmeakin requested wasmtime-compiler-reviewers for a review on PR #9517.
Wasmtime GitHub notifications bot (Oct 29 2024 at 15:45):github-actions[bot] commented on PR #9517:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Oct 29 2024 at 16:08):cfallin submitted PR review:
Thanks! Generally I'm fine with extending the grammar to cover the new stuff; cc @avanhatt for thoughts on documenting this and if/how we want to add more info as well (or perhaps a pointer to the project/paper at least?).
Wasmtime GitHub notifications bot (Oct 29 2024 at 16:08):cfallin created PR review comment:
Can we put these four in a separate
<veri-def>production? In general we haven't documented the verification extensions to ISLE as they're somewhat still in flux; I want to try to keep them separate so as not to confuse users getting started.
Wasmtime GitHub notifications bot (Oct 29 2024 at 16:08):cfallin created PR review comment:
Likewise down here -- let's put all of these in a separate subsection of the grammar, maybe headlined by
# ---- verification extensions ----or something like that?
Wasmtime GitHub notifications bot (Oct 30 2024 at 00:48):Kmeakin updated PR #9517.
Wasmtime GitHub notifications bot (Oct 30 2024 at 14:49):Kmeakin updated PR #9517.
Wasmtime GitHub notifications bot (Oct 30 2024 at 14:49):Kmeakin updated PR #9517.
Wasmtime GitHub notifications bot (Oct 30 2024 at 15:22):cfallin submitted PR review:
Updates LGTM; final signoff from @avanhatt or @mmcloughlin would be great to verify this (thanks!).
Wasmtime GitHub notifications bot (Oct 30 2024 at 15:32):Kmeakin updated PR #9517.
Wasmtime GitHub notifications bot (Oct 31 2024 at 19:51):Kmeakin updated PR #9517.
Wasmtime GitHub notifications bot (Nov 02 2024 at 00:04):avanhatt submitted PR review:
This looks good to me, too, thanks for updating this doc!
Wasmtime GitHub notifications bot (Nov 04 2024 at 19:30):cfallin merged PR #9517.
Last updated: Nov 22 2024 at 16:03 UTC