Stream: git-wasmtime

Topic: wasmtime / PR #9516 bench-api: Allow using `winch` in the...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 29 2024 at 00:33):

saulecabrera requested pchickey for a review on PR #9516.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 29 2024 at 00:33):

saulecabrera requested wasmtime-core-reviewers for a review on PR #9516.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 29 2024 at 00:33):

saulecabrera opened PR #9516 from saulecabrera:winch-bench to bytecodealliance:main:

This commit allows building the bench-api crate via a winch cargo feature. This allows using --engine-flags="-C compiler=winch" for benchmarking.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Oct 29 2024 at 00:38):

saulecabrera submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 29 2024 at 00:38):

saulecabrera created PR review comment:

I decided to go with a feature here, given that winch is still not a default wasmtime feature, however I wonder if it might make sense to unconditionally enable the winch feature in this crate.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 29 2024 at 02:05):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 29 2024 at 02:05):

alexcrichton created PR review comment:

I think it'd be reasonable to enable it by default yeah

view this post on Zulip Wasmtime GitHub notifications bot (Oct 29 2024 at 11:10):

saulecabrera updated PR #9516.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 29 2024 at 11:36):

saulecabrera merged PR #9516.


Last updated: Dec 23 2024 at 13:07 UTC