Wasmtime GitHub notifications bot (Oct 29 2024 at 00:33): Wasmtime GitHub notifications bot (Oct 29 2024 at 00:33):saulecabrera requested pchickey for a review on PR #9516.
Wasmtime GitHub notifications bot (Oct 29 2024 at 00:33):saulecabrera requested wasmtime-core-reviewers for a review on PR #9516.
Wasmtime GitHub notifications bot (Oct 29 2024 at 00:33):saulecabrera opened PR #9516 from saulecabrera:winch-bench to bytecodealliance:main:
This commit allows building the
bench-apicrate via awinchcargo feature. This allows using--engine-flags="-C compiler=winch"for benchmarking.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 29 2024 at 00:38):saulecabrera submitted PR review.
Wasmtime GitHub notifications bot (Oct 29 2024 at 00:38):saulecabrera created PR review comment:
I decided to go with a feature here, given that
winchis still not a default wasmtime feature, however I wonder if it might make sense to unconditionally enable thewinchfeature in this crate.
Wasmtime GitHub notifications bot (Oct 29 2024 at 02:05):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Oct 29 2024 at 02:05):alexcrichton created PR review comment:
I think it'd be reasonable to enable it by default yeah
Wasmtime GitHub notifications bot (Oct 29 2024 at 11:10):saulecabrera updated PR #9516.
Wasmtime GitHub notifications bot (Oct 29 2024 at 11:36):saulecabrera merged PR #9516.
Last updated: Nov 22 2024 at 16:03 UTC