abrown opened PR #9513 from abrown:refactor-type-conversion
to bytecodealliance:main
:
While poking with @alexcrichton at how component core types are translated (or not, as we found), we realized that the
WasmparserTypeConverter
doesn't need an entireModule
in order lookup type indices. In fact, we were previously passing emptyModule
s in cases where no lookups were needed. This change threads through a closure instead, which should help later with component core types when we certainly won't have aModule
.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
abrown requested elliottt for a review on PR #9513.
abrown requested wasmtime-compiler-reviewers for a review on PR #9513.
abrown requested wasmtime-core-reviewers for a review on PR #9513.
abrown edited PR #9513:
While around poking with @alexcrichton at how component core types are translated (or not, as we found), we realized that the
WasmparserTypeConverter
doesn't need an entireModule
in order lookup type indices. In fact, we were previously passing emptyModule
s in cases where no lookups were needed. This change threads through a closure instead, which should help later with component core types when we certainly won't have aModule
.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
abrown edited PR #9513:
While poking around with @alexcrichton at how component core types are translated (or not, as we found), we realized that the
WasmparserTypeConverter
doesn't need an entireModule
in order lookup type indices. In fact, we were previously passing emptyModule
s in cases where no lookups were needed. This change threads through a closure instead, which should help later with component core types when we certainly won't have aModule
.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
github-actions[bot] commented on PR #9513:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
alexcrichton submitted PR review.
alexcrichton merged PR #9513.
Last updated: Dec 23 2024 at 12:05 UTC