Stream: git-wasmtime

Topic: wasmtime / PR #9493 Enable --all-features and display fea...

Wasmtime GitHub notifications bot (Oct 22 2024 at 07:45):

nihalpasham requested elliottt for a review on PR #9493.

Wasmtime GitHub notifications bot (Oct 22 2024 at 07:45):

nihalpasham opened PR #9493 from nihalpasham:main to bytecodealliance:main:

Summary

• Enabled --all-features for Cranelift documentation via:
  toml [package.metadata.docs.rs] all-features = true

• Added #![cfg_attr(docsrs, feature(doc_auto_cfg))] to display feature requirements in documentation when building on docs.rs.

• Verified functionality using:
  bash RUSTDOCFLAGS="--cfg docsrs" cargo +nightly doc --open

Wasmtime GitHub notifications bot (Oct 22 2024 at 07:45):

nihalpasham requested wasmtime-compiler-reviewers for a review on PR #9493.

Wasmtime GitHub notifications bot (Oct 22 2024 at 08:53):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Oct 22 2024 at 08:53):

bjorn3 created PR review comment:

You need to add this to cranelift/codegen/Cargo.toml, not cranelift/Cargo.toml. cranelift/Cargo.toml is for the cranelift-tools crate which isn't published to crates.io anyway. Also instead of enabling all non-default features, I would suggest only enabling all-arch. Some like souper-harvest and disas don't affect the public api while still making building the documentation slower.

Wasmtime GitHub notifications bot (Oct 22 2024 at 10:10):

nihalpasham updated PR #9493.

Wasmtime GitHub notifications bot (Oct 22 2024 at 10:19):

nihalpasham submitted PR review.

Wasmtime GitHub notifications bot (Oct 22 2024 at 10:19):

nihalpasham created PR review comment:

• Updated cranelift/codegen/Cargo.toml to enable the all-arch feature:
  toml [package.metadata.docs.rs] features = ["all-arch"]

• Verified feature requirements are displayed in the docs using:
  bash RUSTDOCFLAGS="--cfg docsrs" cargo +nightly doc --open

Wasmtime GitHub notifications bot (Oct 22 2024 at 14:49):

alexcrichton submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Oct 22 2024 at 15:06):

alexcrichton merged PR #9493.

Last updated: Dec 23 2024 at 12:05 UTC