Stream: git-wasmtime

Topic: wasmtime / PR #9490 winch: Improve tunables/configuration...

Wasmtime GitHub notifications bot (Oct 20 2024 at 21:33):

saulecabrera requested wasmtime-core-reviewers for a review on PR #9490.

Wasmtime GitHub notifications bot (Oct 20 2024 at 21:33):

saulecabrera requested pchickey for a review on PR #9490.

Wasmtime GitHub notifications bot (Oct 20 2024 at 21:33):

saulecabrera opened PR #9490 from saulecabrera:improve-winch-tunables-validation to bytecodealliance:main:

This commit introduces proper validation and documentation to handle the engine features not currently supported by Winch (e.g., consume_fuel, follow-up to the discussion in
https://github.com/bytecodealliance/wasmtime/pull/9472).

In this commit, the tunables validation is done at the set_tunables method in Winch's wasmtime_environ::compile::CompilerBuilder implemetation, which enables removing Winch specific logic from Config::validate

This change also introduces the question of how to consolidate the compiler specific flags with Winch (e.g, the user-specified cranelift_* options) given that not all of them are applicable to Winch (e.g., cranelift_debug_verifier,
cranelift_nan_canonicalization), this change doesn't introduce any functionality on this front, however, it's probably something worth considering/discussing.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 20 2024 at 22:44):

github-actions[bot] commented on PR #9490:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config", "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Oct 20 2024 at 23:44):

github-actions[bot] commented on PR #9490:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

• [ ] If you added a new Config method, you wrote extensive documentation for
  it.

  <details>

  Our documentation should be of the following form:

  ```text
  Short, simple summary sentence.

  More details. These details can be multiple paragraphs. There should be
  information about not just the method, but its parameters and results as
  well.

  Is this method fallible? If so, when can it return an error?

  Can this method panic? If so, when does it panic?

  Example

  Optional example here.
  ```

  </details>

• [ ] If you added a new Config method, or modified an existing one, you
  ensured that this configuration is exercised by the fuzz targets.

  <details>

  For example, if you expose a new strategy for allocating the next instance
  slot inside the pooling allocator, you should ensure that at least one of our
  fuzz targets exercises that new strategy.

  Often, all that is required of you is to ensure that there is a knob for this
  configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
  of its nested structs).

  Rarely, this may require authoring a new fuzz target to specifically test this
  configuration. See [our docs on fuzzing][fuzzing-docs] for more details.

  </details>

• [ ] If you are enabling a configuration option by default, make sure that it
  has been fuzzed for at least two weeks before turning it on by default.

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html

---

<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

Wasmtime GitHub notifications bot (Oct 21 2024 at 09:11):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Oct 21 2024 at 09:30):

alexcrichton commented on PR #9490:

For the fuzz failure I might recommend updating somewhere around here to switch back to Cranelift if epochs (or other Winch-unsupported configs) are enabled during fuzzing

Wasmtime GitHub notifications bot (Oct 21 2024 at 11:24):

saulecabrera requested elliottt for a review on PR #9490.

Wasmtime GitHub notifications bot (Oct 21 2024 at 11:24):

saulecabrera updated PR #9490.

Wasmtime GitHub notifications bot (Oct 21 2024 at 11:24):

saulecabrera requested wasmtime-fuzz-reviewers for a review on PR #9490.

Wasmtime GitHub notifications bot (Oct 21 2024 at 12:54):

github-actions[bot] commented on PR #9490:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "fuzzing"

Thus the following users have been cc'd because of the following labels:

• fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Oct 21 2024 at 16:45):

saulecabrera updated PR #9490.

Wasmtime GitHub notifications bot (Oct 22 2024 at 17:23):

saulecabrera updated PR #9490.

Wasmtime GitHub notifications bot (Oct 22 2024 at 17:53):

saulecabrera merged PR #9490.

Last updated: Oct 23 2024 at 20:03 UTC