Wasmtime GitHub notifications bot (Oct 17 2024 at 12:19): Wasmtime GitHub notifications bot (Oct 17 2024 at 12:19):saulecabrera opened PR #9480 from saulecabrera:winch-remove-allow-dead-code-directives to bytecodealliance:main:
This commit simply removes some
#[allow(dead_code)]which are no longer needed as well as the the notion of callee-saved registers.The notion of callee-saved registers was primarily used in the early days when Winch generated its own trampolines, however, trampolines are now emitted through Cranelift.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 17 2024 at 12:19):saulecabrera requested wasmtime-compiler-reviewers for a review on PR #9480.
Wasmtime GitHub notifications bot (Oct 17 2024 at 12:19):saulecabrera requested cfallin for a review on PR #9480.
Wasmtime GitHub notifications bot (Oct 17 2024 at 12:35):saulecabrera updated PR #9480.
Wasmtime GitHub notifications bot (Oct 17 2024 at 13:45):github-actions[bot] commented on PR #9480:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Oct 21 2024 at 09:32):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Oct 21 2024 at 09:48):alexcrichton merged PR #9480.
Last updated: Nov 22 2024 at 16:03 UTC