Stream: git-wasmtime

Topic: wasmtime / PR #9476 A couple minor Wasm GC codegen improv...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2024 at 18:51):

fitzgen opened PR #9476 from fitzgen:minor-gc-codegen-improvements to bytecodealliance:main:

  1. Don't bounds-check GC refs that are returned from trusted libcalls
  2. Mark loading the DRC collector's activations table pointer from the vmctx as readonly

Also a minor refactor to emitting code to get the GC heap base and bound that resulted in a mechanical value renumbering in the GC disas tests. See each commit in isolation for better diffs.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2024 at 18:51):

fitzgen requested alexcrichton for a review on PR #9476.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2024 at 18:51):

fitzgen requested wasmtime-core-reviewers for a review on PR #9476.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2024 at 20:27):

fitzgen updated PR #9476.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2024 at 21:58):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2024 at 21:58):

alexcrichton created PR review comment:

Is the with_readonly here going to be accurate in the future? If I understand this right it's akin to memory.size which is readonly if memory.grow can't be used, but if we support for example more dynamic configurations of GC heaps in the future will this still be true?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2024 at 21:58):

alexcrichton created PR review comment:

Similar to below, is this with_readonly going to be true in the face of a dynamic GC heap that can move in the future?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 17 2024 at 01:04):

github-actions[bot] commented on PR #9476:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "wasmtime:ref-types"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Oct 17 2024 at 15:17):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 17 2024 at 15:17):

fitzgen created PR review comment:

This code will all be refactored quite a bit for when we support backing GC heaps with linear memories and the static vs dynamic knobs and all that. This is really just for in the meantime, and to split out from some other stuff I am working on.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 17 2024 at 15:33):

fitzgen merged PR #9476.


Last updated: Dec 23 2024 at 13:07 UTC