Stream: git-wasmtime

Topic: wasmtime / PR #9459 Add I128 atomic support to the `x64` ...

Wasmtime GitHub notifications bot (Oct 13 2024 at 17:03):

beetrees opened PR #9459 from beetrees:atomic-128-x64 to bytecodealliance:main:

Rust is currently in the process of stabilising 128-bit atomics (https://github.com/rust-lang/rust/issues/99069#issuecomment-2142718778), but Cranelift (and therefore rustc_codegen_cranelift) doesn't currently support 128-bit atomics.

This PR adds IR support for 128-bit atomics and implements lowering them for the x64 backend using cmpxchg16b.

Wasmtime GitHub notifications bot (Oct 13 2024 at 17:03):

beetrees requested alexcrichton for a review on PR #9459.

Wasmtime GitHub notifications bot (Oct 13 2024 at 17:03):

beetrees requested wasmtime-fuzz-reviewers for a review on PR #9459.

Wasmtime GitHub notifications bot (Oct 13 2024 at 17:03):

beetrees requested fitzgen for a review on PR #9459.

Wasmtime GitHub notifications bot (Oct 13 2024 at 17:03):

beetrees requested wasmtime-compiler-reviewers for a review on PR #9459.

Wasmtime GitHub notifications bot (Oct 13 2024 at 17:03):

beetrees requested wasmtime-core-reviewers for a review on PR #9459.

Wasmtime GitHub notifications bot (Oct 13 2024 at 18:19):

beetrees updated PR #9459.

Wasmtime GitHub notifications bot (Oct 13 2024 at 20:44):

github-actions[bot] commented on PR #9459:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "cranelift:meta", "fuzzing", "isle", "wasmtime:api", "wasmtime:config"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: fuzzing, isle

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Oct 13 2024 at 20:45):

github-actions[bot] commented on PR #9459:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

• [ ] If you added a new Config method, you wrote extensive documentation for
  it.

  <details>

  Our documentation should be of the following form:

  ```text
  Short, simple summary sentence.

  More details. These details can be multiple paragraphs. There should be
  information about not just the method, but its parameters and results as
  well.

  Is this method fallible? If so, when can it return an error?

  Can this method panic? If so, when does it panic?

  Example

  Optional example here.
  ```

  </details>

• [ ] If you added a new Config method, or modified an existing one, you
  ensured that this configuration is exercised by the fuzz targets.

  <details>

  For example, if you expose a new strategy for allocating the next instance
  slot inside the pooling allocator, you should ensure that at least one of our
  fuzz targets exercises that new strategy.

  Often, all that is required of you is to ensure that there is a knob for this
  configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
  of its nested structs).

  Rarely, this may require authoring a new fuzz target to specifically test this
  configuration. See [our docs on fuzzing][fuzzing-docs] for more details.

  </details>

• [ ] If you are enabling a configuration option by default, make sure that it
  has been fuzzed for at least two weeks before turning it on by default.

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html

---

<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

Wasmtime GitHub notifications bot (Oct 14 2024 at 16:13):

fitzgen submitted PR review:

Very nice, thanks!

Wasmtime GitHub notifications bot (Oct 14 2024 at 16:13):

fitzgen created PR review comment:

                    // This will clobber `temp_high`

Wasmtime GitHub notifications bot (Oct 14 2024 at 16:13):

fitzgen updated PR #9459.

Wasmtime GitHub notifications bot (Oct 14 2024 at 16:13):

fitzgen has enabled auto merge for PR #9459.

Wasmtime GitHub notifications bot (Oct 14 2024 at 17:54):

beetrees commented on PR #9459:

I think CI might be stuck? Test macOS x86_64 (wasmtime-cli) seems to have been stuck on cargo fetch --locked for over an hour.

Wasmtime GitHub notifications bot (Oct 14 2024 at 18:05):

beetrees commented on PR #9459:

Never mind, its managed to move on to the next step.

Wasmtime GitHub notifications bot (Oct 14 2024 at 18:06):

beetrees edited a comment on PR #9459:

Never mind, it's managed to move on to the next step.

Wasmtime GitHub notifications bot (Oct 14 2024 at 18:51):

beetrees commented on PR #9459:

It seems to have got stuck in the ./ci/run-tests.sh step now (first it was stuck at the very start of the step for around 30 mins, and now it's stuck at Compiling bytesize v1.3.0).

Wasmtime GitHub notifications bot (Oct 14 2024 at 21:33):

fitzgen commented on PR #9459:

I've been seeing a lot of network issues in github actions the last week or so

Wasmtime GitHub notifications bot (Oct 14 2024 at 21:48):

fitzgen merged PR #9459.

Last updated: Dec 23 2024 at 12:05 UTC