Wasmtime GitHub notifications bot (Oct 10 2024 at 17:09): Wasmtime GitHub notifications bot (Oct 10 2024 at 17:09):fitzgen requested alexcrichton for a review on PR #9446.
Wasmtime GitHub notifications bot (Oct 10 2024 at 17:09):fitzgen requested wasmtime-core-reviewers for a review on PR #9446.
Wasmtime GitHub notifications bot (Oct 10 2024 at 17:09):fitzgen opened PR #9446 from fitzgen:enable-misc-gc-spec-tests to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 10 2024 at 17:12):fitzgen updated PR #9446.
Wasmtime GitHub notifications bot (Oct 10 2024 at 17:41):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Oct 10 2024 at 17:46):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Oct 10 2024 at 17:46):alexcrichton created PR review comment:
Looks like some of these were because there weren't any actual files of that name, so must have been from some historical version of the gc proposal's spec tests or something like that?
Wasmtime GitHub notifications bot (Oct 10 2024 at 17:53):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Oct 10 2024 at 17:53):fitzgen created PR review comment:
I think maybe some didn't have any assertions either? I don't know
Wasmtime GitHub notifications bot (Oct 10 2024 at 17:57):alexcrichton merged PR #9446.
Last updated: Nov 22 2024 at 16:03 UTC