Wasmtime GitHub notifications bot (Oct 10 2024 at 15:08): Wasmtime GitHub notifications bot (Oct 10 2024 at 15:08):fitzgen opened PR #9437 from fitzgen:ref-cast to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 10 2024 at 15:08):fitzgen requested alexcrichton for a review on PR #9437.
Wasmtime GitHub notifications bot (Oct 10 2024 at 15:08):fitzgen requested wasmtime-core-reviewers for a review on PR #9437.
Wasmtime GitHub notifications bot (Oct 10 2024 at 15:09):fitzgen edited PR #9437:
Just building on top of our existing
ref.testsupport and trapping if the test fails.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 10 2024 at 15:15):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Oct 10 2024 at 15:15):alexcrichton created PR review comment:
I can sort of see how this is going to get used for
BrOnCastand such as well. Would it make sense to updatetranslate_ref_testwith an argument along the lines of "what to do as the conclusion"? For example here thetrapzcould get propagated upwards to avoid creating so many basic blocks as part oftranslate_ref_test. ForBrOnCastand friend it could be used for "I already created the blocks and I'm telling you where to jump".Basically there's cleanups we can do here in the frontend which Cranelift will not do in the mid-end. I don't know whether the better answer is to invest in the mid-end, assume that
MachBuffercleans up everything, or try to produce better IR here in the first place.
Wasmtime GitHub notifications bot (Oct 10 2024 at 15:19):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Oct 10 2024 at 15:19):fitzgen created PR review comment:
Yeah, certain things like
trapzs (andjumps/brifs forbr_on_cast[_fail]) could be propagated backwards into theref.testimplementation. I think long-term we want the mid-end to be able to clean this stuff up, just from a separation-of-concerns point of view.I can add an item to the running list of optimizations/code quality improvements for this.
Wasmtime GitHub notifications bot (Oct 10 2024 at 15:22):alexcrichton created PR review comment:
Yeah I just fear that we've talked for a very long time about theoretical mid-end cleanups to basic blocks but haven't gotten to them, so it seems like it's probably easier to do it here than the mid-end.
Wasmtime GitHub notifications bot (Oct 10 2024 at 15:22):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Oct 10 2024 at 15:33):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Oct 10 2024 at 15:33):fitzgen created PR review comment:
Yeah, quite possible it is easier in the front end for now. Either way, not doing it as part of this PR :)
Wasmtime GitHub notifications bot (Oct 10 2024 at 15:36):fitzgen merged PR #9437.
Last updated: Dec 23 2024 at 12:05 UTC