Stream: git-wasmtime

Topic: wasmtime / PR #9423 s390x: Add support for inline probestack

Wasmtime GitHub notifications bot (Oct 09 2024 at 18:08):

uweigand requested abrown for a review on PR #9423.

Wasmtime GitHub notifications bot (Oct 09 2024 at 18:08):

uweigand requested wasmtime-compiler-reviewers for a review on PR #9423.

Wasmtime GitHub notifications bot (Oct 09 2024 at 18:08):

uweigand opened PR #9423 from uweigand:s390x-probestack to bytecodealliance:main:

This implements the gen_inline_probestack callback in line with the implementation on other platforms, which allows detection of stack overflows with misconfigured hosts.

Fixes: https://github.com/bytecodealliance/wasmtime/issues/9396

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 09 2024 at 18:08):

uweigand requested alexcrichton for a review on PR #9423.

Wasmtime GitHub notifications bot (Oct 09 2024 at 18:08):

uweigand requested wasmtime-core-reviewers for a review on PR #9423.

Wasmtime GitHub notifications bot (Oct 09 2024 at 18:27):

uweigand updated PR #9423.

Wasmtime GitHub notifications bot (Oct 09 2024 at 18:38):

alexcrichton submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Oct 09 2024 at 18:38):

alexcrichton created PR review comment:

Mind going ahead and removing this function altogether?

Wasmtime GitHub notifications bot (Oct 09 2024 at 18:46):

uweigand submitted PR review.

Wasmtime GitHub notifications bot (Oct 09 2024 at 18:46):

uweigand created PR review comment:

Sure, will do.

Wasmtime GitHub notifications bot (Oct 09 2024 at 18:50):

uweigand updated PR #9423.

Wasmtime GitHub notifications bot (Oct 09 2024 at 18:58):

uweigand updated PR #9423.

Wasmtime GitHub notifications bot (Oct 09 2024 at 19:11):

alexcrichton has enabled auto merge for PR #9423.

Wasmtime GitHub notifications bot (Oct 09 2024 at 19:28):

alexcrichton merged PR #9423.

Last updated: Oct 23 2024 at 20:03 UTC