Wasmtime GitHub notifications bot (Oct 09 2024 at 15:12): Wasmtime GitHub notifications bot (Oct 09 2024 at 15:12):alexcrichton requested elliottt for a review on PR #9417.
Wasmtime GitHub notifications bot (Oct 09 2024 at 15:12):alexcrichton requested wasmtime-core-reviewers for a review on PR #9417.
Wasmtime GitHub notifications bot (Oct 09 2024 at 15:12):alexcrichton opened PR #9417 from alexcrichton:fix26pr to bytecodealliance:release-26.0.0:
This fixes a bug where we would not properly handle contiguous sequences of Wasm frames that are empty. This was mistakenly believed to be an impossible scenario, and before the tail-calls proposal it was impossible, however it can now happen after the following series of events:
Host calls into Wasm, pushing the entry trampoline frame.
Entry trampoline calls the actual Wasm function, pushing a Wasm frame.
Wasm function tail calls to an imported host function, replacing the Wasm frame with the exit trampoline's frame.
Now we have a stack like
[host, entry trampoline, exit trampoline], which has zero Wasm frames between the entry and exit trampolines. If the host function that the exit trampoline calls out to attempts to capture a backtrace, then -- before this commit -- we would fail an internal assertion and panic. That panic would then unwind to the first Rust frame that is called by Wasm. With Rust 1.81 and later, Rust automatically inserts a panic handler that prevents the unwind from continuing into external/foreign code, which is undefined behavior, and aborts the process. Rust versions before 1.81 would attempt to continue unwinding, hitting undefined behavior.This commit fixes the backtrace capturing machinery to handle empty sequences of Wasm frames, passes the assertion, and avoids unwinding into external/foreign code.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 09 2024 at 15:20):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Oct 09 2024 at 15:24):alexcrichton has enabled auto merge for PR #9417.
Wasmtime GitHub notifications bot (Oct 09 2024 at 15:57):alexcrichton updated PR #9417.
Wasmtime GitHub notifications bot (Oct 09 2024 at 16:12):alexcrichton merged PR #9417.
Last updated: Oct 23 2024 at 20:03 UTC