alexcrichton opened PR #9403 from alexcrichton:wide-arithmetic
to bytecodealliance:main
:
This commit implements the [wide-arithmetic] proposal in Wasmtime. This is a pretty easy proposal to implement due to Cranelift already having support for all the various instructions. The features implemented here are:
- Cranelift support for the four new instructions.
- A new
Config::wasm_wide_arithmetic
option.- A new
-Wwide-arithmetic
CLI flag.- A new
wasmtime_config_wasm_wide_arithmetic_set
C API function.- Support for fuzzing this proposal
- Generation is implemented in
wasm-smith
.- While it's off-by-default in
wasm-smith
it's enabled-by-default here.- Differential execution is only possible against Wasmtime right now.
- Single-instruction module support was added for these new instructions.
- Tests for some simple cases plus randomly-generated tests.
- Example disassemblies for new instructions on Cranelift architectures.
[wide-arithmetic]: https://github.com/WebAssembly/wide-arithmetic
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested fitzgen for a review on PR #9403.
alexcrichton requested wasmtime-fuzz-reviewers for a review on PR #9403.
alexcrichton requested wasmtime-core-reviewers for a review on PR #9403.
alexcrichton requested wasmtime-default-reviewers for a review on PR #9403.
fitzgen submitted PR review:
Very nice!
fitzgen merged PR #9403.
Last updated: Dec 23 2024 at 12:05 UTC