Wasmtime GitHub notifications bot (Oct 08 2024 at 16:07): Wasmtime GitHub notifications bot (Oct 08 2024 at 16:07):uweigand opened PR #9397 from uweigand:s390x-abiregs-cleanup to bytecodealliance:main:
This cleanup removes some places in ISA code where particular register values were hard-coded that actually do not have any particular significance at the ISA level, only in the ABI.
Specifically, the link register for calls is fully determined by the ABI and can be any GPR. In addition, the MovPReg pseudo instruction works correctly as long as the source is any non-allocatable register - this can be checked directly instead of hardcoding a list of registers.
No functional change intended.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 08 2024 at 16:07):uweigand requested elliottt for a review on PR #9397.
Wasmtime GitHub notifications bot (Oct 08 2024 at 16:07):uweigand requested wasmtime-compiler-reviewers for a review on PR #9397.
Wasmtime GitHub notifications bot (Oct 08 2024 at 16:19):elliottt submitted PR review:
Looks good to me, thanks for cleaning this up Ulrich!
Wasmtime GitHub notifications bot (Oct 08 2024 at 16:48):elliottt merged PR #9397.
Last updated: Oct 23 2024 at 20:03 UTC