Wasmtime GitHub notifications bot (Oct 08 2024 at 01:48): Wasmtime GitHub notifications bot (Oct 08 2024 at 01:48):alexcrichton requested fitzgen for a review on PR #9393.
Wasmtime GitHub notifications bot (Oct 08 2024 at 01:48):alexcrichton opened PR #9393 from alexcrichton:fix-under-aligned-empty-mmap-pointer to bytecodealliance:main:
This commit updates platform implementations of
Mmap::new_empty()to use a shared helper to create a pointer with a higher alignment than one. This fixes a debug assert tripping in niche configurations of the pooling allocator where if no virtual memory is given and table lazy init is disabled then a module could trip a debug-only assert about a slice being created from a raw pointer that is not properly aligned. The fix here is to use a helper that starts with an over-aligned empty slice which is then casted down to a byte slice.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 08 2024 at 01:48):alexcrichton requested wasmtime-core-reviewers for a review on PR #9393.
Wasmtime GitHub notifications bot (Oct 08 2024 at 15:31):fitzgen submitted PR review:
:+1:
Wasmtime GitHub notifications bot (Oct 08 2024 at 15:47):fitzgen merged PR #9393.
Last updated: Dec 23 2024 at 13:07 UTC