Stream: git-wasmtime

Topic: wasmtime / PR #9389 Implement the `array.copy` Wasm GC in...

Wasmtime GitHub notifications bot (Oct 07 2024 at 18:19):

fitzgen opened PR #9389 from fitzgen:array-copy to bytecodealliance:main:

This also involved fixing some VMGcRef initialization and GC barrier code for globals. That in turn involved making global initialization fallible, which meant that it needed to be pulled out of vmctx initialization and put into instance initialization.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 07 2024 at 18:19):

fitzgen requested alexcrichton for a review on PR #9389.

Wasmtime GitHub notifications bot (Oct 07 2024 at 18:19):

fitzgen requested wasmtime-core-reviewers for a review on PR #9389.

Wasmtime GitHub notifications bot (Oct 07 2024 at 18:45):

fitzgen updated PR #9389.

Wasmtime GitHub notifications bot (Oct 07 2024 at 18:53):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Oct 07 2024 at 18:53):

alexcrichton created PR review comment:

Looks like MaybeUninit::write returns &mut T so I think this can be let destination = destination.write(None);

Wasmtime GitHub notifications bot (Oct 07 2024 at 18:58):

fitzgen updated PR #9389.

Wasmtime GitHub notifications bot (Oct 07 2024 at 18:58):

fitzgen has enabled auto merge for PR #9389.

Wasmtime GitHub notifications bot (Oct 07 2024 at 19:23):

fitzgen merged PR #9389.

Last updated: Nov 22 2024 at 16:03 UTC