Stream: git-wasmtime

Topic: wasmtime / PR #9374 Fix type interning during Wasm-to-CLI...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2024 at 17:09):

fitzgen requested elliottt for a review on PR #9374.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2024 at 17:09):

fitzgen requested wasmtime-core-reviewers for a review on PR #9374.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2024 at 17:09):

fitzgen opened PR #9374 from fitzgen:fix-out-of-bounds-index-during-type-translation to bytecodealliance:main:

We were handling the case where we had fewer rec groups than types, in the case where a rec group defines multiple types, but were failing to handle the case when we have more rec groups than types due to empty rec groups.

The fix is to bound the loop by the number of types, not the number of rec groups.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2024 at 17:25):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2024 at 18:04):

fitzgen merged PR #9374.


Last updated: Dec 23 2024 at 12:05 UTC