Wasmtime GitHub notifications bot (Oct 04 2024 at 17:09): Wasmtime GitHub notifications bot (Oct 04 2024 at 17:09):fitzgen requested elliottt for a review on PR #9374.
Wasmtime GitHub notifications bot (Oct 04 2024 at 17:09):fitzgen requested wasmtime-core-reviewers for a review on PR #9374.
Wasmtime GitHub notifications bot (Oct 04 2024 at 17:09):fitzgen opened PR #9374 from fitzgen:fix-out-of-bounds-index-during-type-translation to bytecodealliance:main:
We were handling the case where we had fewer rec groups than types, in the case where a rec group defines multiple types, but were failing to handle the case when we have more rec groups than types due to empty rec groups.
The fix is to bound the loop by the number of types, not the number of rec groups.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 04 2024 at 17:25):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Oct 04 2024 at 18:04):fitzgen merged PR #9374.
Last updated: Oct 23 2024 at 20:03 UTC