Wasmtime GitHub notifications bot (Oct 17 2024 at 11:35): Wasmtime GitHub notifications bot (Oct 17 2024 at 11:35):bjorn3 edited PR #9361.
Wasmtime GitHub notifications bot (Oct 17 2024 at 11:36):I removed the call instruction changes. I think it still makes sense to keep them for the ElfTlsGetOffset pseudo-instruction as that one hard codes a single abi anyway.
Wasmtime GitHub notifications bot (Oct 17 2024 at 15:18):uweigand submitted PR review.
Wasmtime GitHub notifications bot (Oct 17 2024 at 15:18):uweigand created PR review comment:
I don't really like this. This function, with this name in this place, gives the wrong impression that this is a ISA-defined register, and encourages additional uses in the future.
If we need a function like this, it should be an ABI function.
In any case, if you really want to hard-code the link register in
ElfTlsGetOffset, then I'd suggest to just hard-code 14 directly, like this code also hard-codes register numbers 12 and 2. (Again, I'd prefer to go the other way and not hard-code any of them, and instead get them from ABI code. But given that this opcode is ABI-specific, I don't really have a strong opinion here.)
Wasmtime GitHub notifications bot (Oct 17 2024 at 16:10):bjorn3 updated PR #9361.
Wasmtime GitHub notifications bot (Oct 17 2024 at 16:10):bjorn3 submitted PR review.
Wasmtime GitHub notifications bot (Oct 17 2024 at 16:10):bjorn3 created PR review comment:
Inlined in all callers.
Wasmtime GitHub notifications bot (Oct 17 2024 at 16:13):bjorn3 updated PR #9361.
Wasmtime GitHub notifications bot (Oct 17 2024 at 16:29):uweigand submitted PR review.
Wasmtime GitHub notifications bot (Oct 17 2024 at 16:29):uweigand created PR review comment:
LGTM now, thanks!
Wasmtime GitHub notifications bot (Oct 17 2024 at 18:17):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Oct 17 2024 at 18:33):cfallin merged PR #9361.
Last updated: Jan 09 2026 at 13:15 UTC