Wasmtime GitHub notifications bot (Oct 02 2024 at 18:30): Wasmtime GitHub notifications bot (Oct 02 2024 at 18:30):fitzgen opened PR #9359 from fitzgen:improve-gc-ref-debug-assertions to bytecodealliance:main:
Don't just assert that the given GC refs aren't
i31refs, but also that they are of the correct type.Note that the other
from_cloned_gc_refmethods (on, for example,AnyRef) already do their equivalents of these checks. Just these two were a little looser than they should have been.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 02 2024 at 18:30):fitzgen requested wasmtime-core-reviewers for a review on PR #9359.
Wasmtime GitHub notifications bot (Oct 02 2024 at 18:30):fitzgen requested alexcrichton for a review on PR #9359.
Wasmtime GitHub notifications bot (Oct 02 2024 at 19:45):github-actions[bot] commented on PR #9359:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
- fitzgen: wasmtime:ref-types
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Oct 02 2024 at 19:58):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Oct 02 2024 at 20:14):alexcrichton merged PR #9359.
Last updated: Oct 23 2024 at 20:03 UTC